Skip to content

Change deprecated kUUTypeUTF8PlainText for UTType #8188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

Change deprecated kUUTypeUTF8PlainText for UTType #8188

merged 1 commit into from
Nov 24, 2022
+3 −2

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Nov 23, 2022

Description

By updating the minimum release version to iOS 15 recently, we've seen some deprecation warnings. This PR fixes the case for uses of kUUTypeUTF8PlainText

Changes

Changed the two references of kUUTypeUTF8PlainText for UTType.utf8PlainText.identifier, in the ProductDownloadDragAndDrop class.

This type is used when we need to represent plain text encoded as UTF-8, this is needed in this case when we attempt to drag and drop elements from our table view. The system will call the writableTypeIdentifiersForItemProvider and readableTypeIdentifiersForItemProvider methods to get information about our encoded data representation while dragging and dropping those elements around.

Testing instructions

  • Create or edit a "Virtual and Downloadable" product from wp-admin
  • Add several downloadable files.
  • Go the app and navigate to the "Downloadable Files" view
  • Try to drag and drop the cells to reorder the files, this should work as expected

Screenshots

Downloadable files Drag and drop

@iamgabrielma iamgabrielma added iOS 15 Specific to iOS 15 type: enhancement A request for an enhancement. feature: add/edit products Related to adding or editing products. labels Nov 23, 2022
@iamgabrielma iamgabrielma added this to the 11.4 milestone Nov 23, 2022
@iamgabrielma iamgabrielma requested a review from toupper November 23, 2022 11:36
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 23, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8188-d681ea8 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@toupper
Copy link
Contributor

toupper commented Nov 24, 2022 •
edited
Loading

Nice! Fewer warnings 🎉 Code is good and tests well :shipit:

@iamgabrielma iamgabrielma merged commit bc2ae95 into trunk Nov 24, 2022
@iamgabrielma iamgabrielma deleted the task/deprecated-kUTTypeUTF8PlainText branch November 24, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toupper toupper toupper approved these changes

Assignees

No one assigned

Labels

feature: add/edit products Related to adding or editing products. iOS 15 Specific to iOS 15 type: enhancement A request for an enhancement.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

4 participants

@iamgabrielma @wpmobilebot @toupper